-
Notifications
You must be signed in to change notification settings - Fork 6k
Add explanation of why the when
contextual keyword is better than if/else in catch blocks
#47887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-40661
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <[email protected]>
when
contextual keywordwhen
contextual keyword is better than if/else in catch blocks
Copilot finished work on behalf of
BillWagner
August 7, 2025 20:46
Rabadash8820
reviewed
Aug 7, 2025
...p/language-reference/statements/snippets/exception-handling-statements/WhenFilterExamples.cs
Outdated
Show resolved
Hide resolved
BillWagner
reviewed
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start.
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
...p/language-reference/statements/snippets/exception-handling-statements/WhenFilterExamples.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
August 8, 2025 14:28
Copilot finished work on behalf of
BillWagner
August 8, 2025 17:08
gewarren
reviewed
Aug 8, 2025
...p/language-reference/statements/snippets/exception-handling-statements/WhenFilterExamples.cs
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
BillWagner
reviewed
Aug 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please address all comments.
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
… formatting Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
August 11, 2025 15:18
BillWagner
approved these changes
Aug 11, 2025
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/exception-handling-statements.md
Outdated
Show resolved
Hide resolved
This is ready for final review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the lack of explanation for why C#'s
when
contextual keyword provides advantages over using if/else statements inside catch blocks. The key technical difference is that exception filters don't unwind the call stack, while traditional catch blocks do.Changes Made
Enhanced exception-handling-statements.md
Added a comprehensive "Exception filters vs. traditional exception handling" section that explains:
when
) evaluate before stack unwinding, preserving the original call stack and local variablesUpdated when.md
Added context explaining the advantages of exception filters with a cross-reference to the detailed explanation in the exception handling statements documentation.
New Code Examples
Created comprehensive working examples in
WhenFilterExamples.cs
demonstrating:Technical Benefits Explained
The documentation now clearly explains why this approach is superior:
The exception filter approach is particularly valuable in production applications where preserving debugging information is crucial for diagnosing issues.
Fixes #40661.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews
throw
,try-catch
,try-finally
, andtry-catch-finally